On Fri, Sep 9, 2011 at 9:24 AM, Ram Durairaj (radurair) <radur...@cisco.com>wrote:
> **** > > **** > > Hope this eliminates some of the confusion. While lp837752 is critical and > we need it for Diablo time frame, unit tests out of lp845140 could be taken > on lower priority and best effort review mode and it’s for this team’s > decision.**** > > ** ** > > I'm not totally clear on this. The above merge link is now dead (I'm > guessing Tyler removed it?), and > https://bugs.launchpad.net/quantum/+bug/845140 doesn't seem to have a > merge request associated with it. If the code is available now, has a > fairly small diff, and passes the first set of reviews, I think we could > squeeze it into diablo. If you're going to try and push for this, please > point us to the branch ASAP. Otherwise we'll just target Essex. **** > > ** ** > > *[Ram Durairaj (radurair)] yes. We will make a merge request immediately > today on *https://bugs.launchpad.net/quantum/+bug/845140 * as it was being > reviewed internally. It would be great if it can make it to Diablo as it > will increase the test coverage.* > > * * > > *Thanks a lot for all your support.* > Ok, branch looked clean so we got this in for diablo. Sounds like we're good. Dan > ** > > * > Ram* > > * * > > Thanks,**** > > ** ** > > Dan**** > > ** ** > > ** ** > > ** ** > > ** ** > > ** ** > > **** > > **** > > Thanks **** > > > Ram**** > > **** > > **** > > **** > > **** > > **** > > **** > > **** > > 15:29] <danwent> we also have some unit tests commits from rohit that do > not have a bug. I'd like to see them go in to improve our coverage.**** > > [15:29] <danwent> but those reviews should be best effort.**** > > [15:29] <salv-orlando> agreed.**** > > [15:29] <danwent> I think there may be another cisco branch with cisco > plugin tests as well.**** > > [15:30] <danwent> ah, looks like that isn't targeting lp:quantum yet though > [15:30] <danwent> rather another cisco branch. my mistake.**** > > [15:30] <danwent> ok, anyone aware of anything else?**** > > [15:30] <dendrobates> danwent: which branch?**** > > [15:30] <danwent> > https://code.launchpad.net/~tylesmit/quantum/unit_tests/+merge/74274**** > > [15:30] <salv-orlando> > https://code.launchpad.net/~tylesmit/quantum/unit_tests/+merge/74274**** > > [15:30] <danwent> :)**** > > [15:30] <salv-orlando> sorry**** > > [15:31] <danwent> pretty much any other changes being pushed to lp:quantum > should be serious bug fixes if they weren't mentioned today.**** > > [15:31] <danwent> we'll open up essex once we release diablo-rbp [15:32] > <danwent> any questions/concerns with the diablo release process?**** > > [15:32] <RamD> danwent: I think this for a bug fix coverage..**** > > [15:32] <danwent> RamD: Ok, so you take is that this is needed for diablo? > **** > > [15:33] <RamD> danwent: yes**** > > [15:33] <danwent> is this handling the multi-nic issue, or is it another > bug?**** > > [15:33] <RamD> yes, multi-nic issue**** > > [15:33] <danwent> if its another bug, let's get it filed and targeted for > diablo-rbp [15:33] <danwent> ah, ok.**** > > [15:33] <dendrobates> this needs to be finished and proposed asap **** > > [15:33] <RamD> yep I'll verify with tyler and will do **** > > [15:33] <dendrobates> or maybe it was mistakenly targeted 15:34] <danwent> > ok, let's get this cleared up and correct on launchpad if anything is > mistaken.**** > > [15:34] <danwent> > https://code.launchpad.net/~cisco-openstack/quantum/lp837752**** > > [15:34] <danwent> is the branch associated with the multi-nic bug **** > > [15:35] <dendrobates> naming your branches the bug number they are > addressing is very helpful [15:35] <RamD> ok will discuss here and take care > of that**** > > **** > > **** > > **** > > **** > > **** > > **** > > **** > > **** > > **** > > > > ---------- Forwarded message ---------- > From: "Tyler Smith" <845...@bugs.launchpad.net> > To: "Ram Durairaj (radurair)" <radur...@cisco.com> > Date: Thu, 8 Sep 2011 13:59:51 -0700 > Subject: [Bug 845140] Re: L2Network plugin's multi-blade model needs unit > tests**** > > ** Branch linked: lp:~tylesmit/quantum/lp845140 **** > > -- > You received this bug notification because you are a member of Netstack > Core Developers, which is subscribed to quantum. > https://bugs.launchpad.net/bugs/845140 **** > > Title: > L2Network plugin's multi-blade model needs unit tests **** > > Status in OpenStack Quantum (virtual network service): > In Progress **** > > Bug description: > The multi-blade model for the L2Network plugin lacks unit testing. **** > > To manage notifications about this bug go to: > https://bugs.launchpad.net/quantum/+bug/845140/+subscriptions **** > > ** ** > > > > **** > > ** ** > > -- > ~~~~~~~~~~~~~~~~~~~~~~~~~~~ > Dan Wendlandt > Nicira Networks, Inc. > www.nicira.com | www.openvswitch.org > Sr. Product Manager > cell: 650-906-2650 > ~~~~~~~~~~~~~~~~~~~~~~~~~~~**** > -- ~~~~~~~~~~~~~~~~~~~~~~~~~~~ Dan Wendlandt Nicira Networks, Inc. www.nicira.com | www.openvswitch.org Sr. Product Manager cell: 650-906-2650 ~~~~~~~~~~~~~~~~~~~~~~~~~~~
-- Mailing list: https://launchpad.net/~netstack Post to : netstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~netstack More help : https://help.launchpad.net/ListHelp
