Hi Dan, Regarding but 818321 (Incosistent integer deserialization) I reckon it would be advisable to follow the 2nd approach you are proposing: "say that the API does not support passing integer values and change the PortCount field to be a string"
However, as you also said in the bug report, PortCount is not anywhere in the specification. So If we all agree we do not want the "get network" operation to return this information we can just remove PortCount from the API; we could do this in the effort we are doing to align the API implementation with the specification (https://bugs.launchpad.net/quantum/+bug/813433). On this regard, I would like to reiterate that a thread on the NetStack Mailing List was already started last week, "Aligning the API code with the specification". The API specification was reviewed in order to ensure it was consistent with the Openstack API, and I would be more than happy to receive your feedback. Cheers, Salvatore From: Dan Wendlandt [mailto:d...@nicira.com] Sent: 30 July 2011 04:04 To: Somik Behera Cc: Salvatore Orlando; Santhosh Kumar M; netstack@lists.launchpad.net Subject: Re: [Netstack] reviews, merges, and next steps Great work on the fixes + reviews folks. We now are much closer to having having trunk's unit tests running clean for a D-3 drop. There are two remaining bugs with the unit tests, one of which was discovered only after the other tests were merged into trunk: - https://bugs.launchpad.net/quantum/+bug/818321 - https://bugs.launchpad.net/quantum/+bug/814518 We're hoping to wrap these up soon and have a drop on monday. Dan On Fri, Jul 29, 2011 at 10:56 AM, Somik Behera <so...@nicira.com<mailto:so...@nicira.com>> wrote: This is a long awaited branch! It had slipped me, I'll review it soon. Thanks, Somik On Fri, Jul 29, 2011 at 8:45 AM, Salvatore Orlando <salvatore.orla...@eu.citrix.com<mailto:salvatore.orla...@eu.citrix.com>> wrote: Hi, I would like to add that the branch that fixes most of the failing tests is: https://code.launchpad.net/~salvatore-orlando/quantum/quantum-api/+merge/65979 This branch has been waiting for a review for a week now. The "needs fixing" vote that you see on the merge proposal is related to a previous revision of the branch. Comments in that review have already been addressed. Thanks, Salvatore From: netstack-bounces+salvatore.orlando=eu.citrix.com<http://eu.citrix.com>@lists.launchpad.net<http://lists.launchpad.net> [mailto:netstack-bounces+salvatore.orlando<mailto:netstack-bounces%2Bsalvatore.orlando>=eu.citrix.com<http://eu.citrix.com>@lists.launchpad.net<http://lists.launchpad.net>] On Behalf Of Dan Wendlandt Sent: 29 July 2011 15:43 To: Santhosh Kumar M Cc: netstack@lists.launchpad.net<mailto:netstack@lists.launchpad.net> Subject: Re: [Netstack] reviews, merges, and next steps Thanks for pointing that out Santhosh. To avoid confusion, I updated the status of the old merge request from "work in progress" to "rejected" to indicate that it is no longer expected to be merged (this should keep the history around, as I did not delete the merge request). The new merge request is still active. Thanks, Dan On Thu, Jul 28, 2011 at 9:42 PM, Santhosh Kumar M <sant...@thoughtworks.com<mailto:sant...@thoughtworks.com>> wrote: Hi Dan, There is one correction in the api-extensions merge prop. The latest merge prop is https://code.launchpad.net/~raxnetworking/quantum/api_extensions. This branch supports dynamically enabling/disabling extensions for the plugin. The link you have mentioned is the old branch, we left that prop to keep a log of the discussions happened. On Fri, Jul 29, 2011 at 8:59 AM, Dan Wendlandt <d...@nicira.com<mailto:d...@nicira.com>> wrote: Ok, so we're trying to clear a bunch of small bugs out the the pipeline, should be easy reviews: - https://code.launchpad.net/~tylesmit/quantum/quantum-bug-814517/+merge/69477 - https://code.launchpad.net/~danwent/quantum/bug814012/+merge/69505 - https://code.launchpad.net/~danwent/quantum/bug817813/+merge/69737 I believe we're one more bug away from having clean unit tests: - https://bugs.launchpad.net/quantum/+bug/814518 I can handle that one, but I'm waiting on some input from Salvatore regarding the 'spec'. My goal is to get these fixes reviewed and merged tomorrow, so please help out. At that point, we should be able to do a bit of sanity testing and cut a Diable-3 drop, then open the door up for Diablo-4 items. First items on the table for Quantum code base in D-4 will be the client-lib + api extensions, already proposed for merging: - https://code.launchpad.net/~tylesmit/quantum/quantum-client-library-proper - https://code.launchpad.net/~santhoshkumar/quantum/api_extensions Diablo-4 will also have a lot of the Quantum related work in Nova. I'm planning on creating "shadow" quantum blueprints that point to the nova blueprints so we can easily track what is in our next milestone. Dan -- ~~~~~~~~~~~~~~~~~~~~~~~~~~~ Dan Wendlandt Nicira Networks, Inc. www.nicira.com<http://www.nicira.com> | www.openvswitch.org<http://www.openvswitch.org> Sr. Product Manager cell: 650-906-2650<tel:650-906-2650> ~~~~~~~~~~~~~~~~~~~~~~~~~~~ -- Mailing list: https://launchpad.net/~netstack Post to : netstack@lists.launchpad.net<mailto:netstack@lists.launchpad.net> Unsubscribe : https://launchpad.net/~netstack More help : https://help.launchpad.net/ListHelp -- Thanks, Santhosh -- ~~~~~~~~~~~~~~~~~~~~~~~~~~~ Dan Wendlandt Nicira Networks, Inc. www.nicira.com<http://www.nicira.com> | www.openvswitch.org<http://www.openvswitch.org> Sr. Product Manager cell: 650-906-2650<tel:650-906-2650> ~~~~~~~~~~~~~~~~~~~~~~~~~~~ -- Mailing list: https://launchpad.net/~netstack Post to : netstack@lists.launchpad.net<mailto:netstack@lists.launchpad.net> Unsubscribe : https://launchpad.net/~netstack More help : https://help.launchpad.net/ListHelp -- Somik Behera | Nicira Networks, Inc. | so...@nicira.com<mailto:sbeh...@nicira.com> | office: 650-390-6790<tel:650-390-6790> | cell: 512-577-6645<tel:512-577-6645> -- ~~~~~~~~~~~~~~~~~~~~~~~~~~~ Dan Wendlandt Nicira Networks, Inc. www.nicira.com<http://www.nicira.com> | www.openvswitch.org<http://www.openvswitch.org> Sr. Product Manager cell: 650-906-2650<tel:650-906-2650> ~~~~~~~~~~~~~~~~~~~~~~~~~~~
-- Mailing list: https://launchpad.net/~netstack Post to : netstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~netstack More help : https://help.launchpad.net/ListHelp
