Review: Needs Information netstack-core Great work on this changelist Salvatore! This was much needed. I do have a few questions, while not directly related to this branch, they did bring up questions in my mind around our official API Spec? I felt the Error codes weren't correct and looking at the API Spec wiki, it seems the wiki has another completely separate list of error codes.
Which is the API spec that you are working off? Just so that we can all be on the same page and update the spec. from a single source. I think besides that we are very close to checking in. I just wouldn't want our unit test to giving us "green" light even when they are diverging from our Spec., thats why I had these questions. 1) The WSGI logging, at debug level can be helpful. 2) What's the motivation for introducing options in the ABC? Currently all plugin specific config is inside the plugin. Why introduce this for FakePlugin? 3) def _test_show_network_not_found(self, format): -- HTTP code for Not Found is 404, why are we asserting 420? 4) def _test_rename_network(self, format): -- The final assert violates the data format of specified in quantum_plugin_base. The 'id' should be 'net-id' and name should be 'net-name' 5) Also as for 202, shouldn't we use 200:OK ( Request Completed) rather than 202: Accepted ( accepted for processing without guarantees of completion.) 6) def _test_delete_network_in_use(self, format): -- I see 421 here, no idea what does that represent. 7) def _test_show_port_portnotfound(self, format): -- ERROR code 430? 8) _test_delete_port_in_use(self, format): - We have 432 here, can we use well defined error codes from here - http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html 9) I also noticed that the error are not consistent with what we have in the API Spec - http://wiki.openstack.org/QuantumAPISpec but we can tackle those as bugs but our unit tests should reflect them as bugs. -- https://code.launchpad.net/~netstack/quantum/quantum-unit-tests/+merge/68308 Your team Netstack is subscribed to branch lp:~netstack/quantum/quantum-unit-tests. -- Mailing list: https://launchpad.net/~netstack Post to : netstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~netstack More help : https://help.launchpad.net/ListHelp
