Re: [PATCH net] ppp: lock ppp->flags in ppp_read() and ppp_poll()

[David Miller]

From: Guillaume Nault <g.na...@alphalink.fr>
Date: Fri, 26 Feb 2016 18:45:34 +0100

> @@ -443,9 +443,14 @@ static ssize_t ppp_read(struct file *file, char __user 
> *buf,
>                        * network traffic (demand mode).
>                        */
>                       struct ppp *ppp = PF_TO_PPP(pf);
> +
> +                     ppp_recv_lock(ppp);
>                       if (ppp->n_channels == 0 &&
> -                         (ppp->flags & SC_LOOP_TRAFFIC) == 0)
> +                         (ppp->flags & SC_LOOP_TRAFFIC) == 0) {
> +                             ppp_recv_unlock(ppp);
>                               break;
> +                     }

I agree with this change because these two tests much be done without either
of them changing meanwhile, so I'll apply this to 'net', thanks!