On Tue, Mar 1, 2016 at 9:42 AM, Sowmini Varadhan
<sowmini.varad...@oracle.com> wrote:
>
> John,
>
> I'm getting a failure when I try to build the latest net-next. I see
>
> net/sched/sch_mqprio.c: In function `mqprio_init':
> net/sched/sch_mqprio.c:145: error: unknown field `tc' specified in initializer
> net/sched/sch_mqprio.c:145: warning: missing braces around initializer
> net/sched/sch_mqprio.c:145: warning: (near initialization for
> `tc.<anonymous>')
> make[2]: *** [net/sched/sch_mqprio.o] Error 1
>
> I'm not sure why this wasn't noticed before, but in case this is due to my
> compiler version:
> # gcc --version
> gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-16)
> Copyright (C) 2010 Free Software Foundation, Inc.
>
> I'm finding that the minimum fix to avoid this error should be something like
>
Why not just initialize these fields explicitly? For example,
diff --git a/net/sched/sch_mqprio.c b/net/sched/sch_mqprio.c
index f9947d1..19323b6 100644
--- a/net/sched/sch_mqprio.c
+++ b/net/sched/sch_mqprio.c
@@ -28,7 +28,7 @@ static void mqprio_destroy(struct Qdisc *sch)
{
struct net_device *dev = qdisc_dev(sch);
struct mqprio_sched *priv = qdisc_priv(sch);
- struct tc_to_netdev tc = {.type = TC_SETUP_MQPRIO};
+ struct tc_to_netdev tc;
unsigned int ntx;
if (priv->qdiscs) {
@@ -39,6 +39,7 @@ static void mqprio_destroy(struct Qdisc *sch)
kfree(priv->qdiscs);
}
+ tc.type = TC_SETUP_MQPRIO;
if (priv->hw_owned && dev->netdev_ops->ndo_setup_tc)
dev->netdev_ops->ndo_setup_tc(dev, sch->handle, 0, &tc);
else
