> From: Ivan Vecera [mailto:ivec...@redhat.com]
> Sent: Friday, February 26, 2016 12:16 AM
>
> Use list_move_tail() to move MAC address entry from list of pending to list
> of active entries. Simple list_add_tail() leaves the entry also in the first
> list,
> this leads to list corruption.
>
> Cc: Rasesh Mody <rasesh.m...@qlogic.com>
> Signed-off-by: Ivan Vecera <ivec...@redhat.com>
Acked-by: Rasesh Mody <rasesh.m...@qlogic.com>
> ---
> drivers/net/ethernet/brocade/bna/bna_tx_rx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/brocade/bna/bna_tx_rx.c
> b/drivers/net/ethernet/brocade/bna/bna_tx_rx.c
> index 04b0d16..95bc470 100644
> --- a/drivers/net/ethernet/brocade/bna/bna_tx_rx.c
> +++ b/drivers/net/ethernet/brocade/bna/bna_tx_rx.c
> @@ -987,7 +987,7 @@ bna_rxf_ucast_cfg_apply(struct bna_rxf *rxf)
> if (!list_empty(&rxf->ucast_pending_add_q)) {
> mac = list_first_entry(&rxf->ucast_pending_add_q,
> struct bna_mac, qe);
> - list_add_tail(&mac->qe, &rxf->ucast_active_q);
> + list_move_tail(&mac->qe, &rxf->ucast_active_q);
> bna_bfi_ucast_req(rxf, mac,
> BFI_ENET_H2I_MAC_UCAST_ADD_REQ);
> return 1;
> }
> --
> 2.4.10
