From: Chunhao Lin <h...@realtek.com> Date: Thu, 18 Feb 2016 22:57:07 +0800
> There will be a log spam when there is no cable plugged. > Please refer to following links. > https://bugzilla.kernel.org/show_bug.cgi?id=104351 > https://bugzilla.kernel.org/show_bug.cgi?id=107421 > > This issue is caused by runtime power management. When there is no cable > plugged, the driver will be suspend (runtime suspend) by OS and NIC will > be put into the D3 state. During this time, if OS call rtl8169_get_stats64() > to dump tally counter, because NIC is in D3 state, the register value read by > driver will return all 0xff. This will let driver think tally counter flag is > not > toggled and then sends the warning message "rtl_counters_cond == 1 (loop: > 1000, > delay: 10)" to kernel log. > > I add checking driver's pm runtime status in rtl8169_get_stats64() to fix > this issue. > > Signed-off-by: Chunhao Lin <h...@realtek.com> If you are going to do this, then you need to quiesce the device RX/TX and capture all of the statistics from the chip before suspending it. Otherwise what we're returning from rtl8169_get_stats64() is inaccurate.
