> From: Intel-wired-lan [intel-wired-lan-boun...@lists.osuosl.org] on behalf of > Stefan Assmann [sassm...@kpanic.de] > Sent: Wednesday, February 03, 2016 12:20 AM > To: intel-wired-...@lists.osuosl.org > Cc: netdev@vger.kernel.org; da...@davemloft.net; sassm...@kpanic.de > Subject: [Intel-wired-lan] [PATCH net-next V2 6/6] e1000e: call ndo_stop() > instead of dev_close() when running offline selftest > > Calling dev_close() causes IFF_UP to be cleared which will remove the > interfaces routes and some addresses. That's probably not what the user > intended when running the offline selftest. Besides this does not happen > if the interface is brought down before the test, so the current > behaviour is inconsistent. > Instead call the net_device_ops ndo_stop function directly and avoid > touching IFF_UP at all. > > V2: rename e1000_open(), e1000_close() to e1000e_open(), e1000e_close() > to avoid name clash with e1000. > > Signed-off-by: Stefan Assmann <sassm...@kpanic.de> > --- > drivers/net/ethernet/intel/e1000e/e1000.h | 2 ++ > drivers/net/ethernet/intel/e1000e/ethtool.c | 4 ++-- > drivers/net/ethernet/intel/e1000e/netdev.c | 12 ++++++------ > 3 files changed, 10 insertions(+), 8 deletions(-)
Tested-by: Aaron Brown <aaron.f.br...@intel.com>
