Re: [PATCH/RFC v4 net-next] ravb: Add dma queue interrupt support

[Sergei Shtylyov]

On 02/07/2016 07:56 PM, Yoshihiro Kaneko wrote:

From: Kazuya Mizuguchi <kazuya.mizuguchi...@renesas.com>

This patch supports the following interrupts.

- One interrupt for multiple (descriptor, error, management)
- One interrupt for emac
- Four interrupts for dma queue (best effort rx/tx, network control rx/tx)

This patch improve efficiency of the interrupt handler by adding the
interrupt handler corresponding to each interrupt source described
above. Additionally, it reduces the number of times of the access to
EthernetAVB IF.

Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi...@renesas.com>
Signed-off-by: Yoshihiro Kaneko <ykaneko0...@gmail.com>

[...]

diff --git a/drivers/net/ethernet/renesas/ravb_main.c
b/drivers/net/ethernet/renesas/ravb_main.c
index ac43ed9..076f25f 100644
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c

[...]

@@ -1215,29 +1332,64 @@ static const struct ethtool_ops ravb_ethtool_ops =
{
         .get_ts_info            = ravb_get_ts_info,
   };

+static inline int hook_irq(unsigned int irq, irq_handler_t handler,
+                          struct net_device *ndev, struct device *dev,
+                          const char *ch)
+{
+       char *name;
+       int error;
+
+       name = devm_kasprintf(dev, GFP_KERNEL, "%s:%s", ndev->name, ch);

    BTW, shouldn't we test 'name' for NULL here?

Thanks.
I will fix it to return -ENOMEM if 'name' is NULL.

   Be sure to use '!name' -- it's preferred in the networking code.

Thanks,
kaneko

MBR, Sergei