On 16-02-01 01:31 AM, John Fastabend wrote: > On 16-02-01 12:34 AM, Amir Vadai wrote: >> During initialization, tcf_exts_offload_init() is called to initialize >> the list of actions description. later on, the classifier description >> is prepared and sent to the switchdev using switchdev_port_flow_add(). >> >> When offloaded, fl_classify() is a NOP - already done in hardware. >> >> Signed-off-by: Amir Vadai <a...@vadai.me> >> --- > > You need to account for where the classifier is being loaded > by passing the handle as I did in my patch set. Otherwise you may > be offloading on egress/ingress or even some qdisc multiple layers > down in the hierarchy. > > .John >
Hi Amir, I've read through the patches take a look at my set and see if you can add this as another TC_SETUP_* command namely TC_SETUP_FLOWER. The switchdev bits could be handled the same way as fdb_add and other ndo ops are handled today in rocker. I don't think your set of patches would have to change much to merge them with my set. I'll take a stab at it tomorrow and send out a v2. I think this would work and then NIC can implement just the tc_setup ndo and your switchdev patches remain unchanged. Thanks, John
