On Fri, 2016-01-29 at 18:49 -0800, Alexander Duyck wrote: > This patch fixes an issue with unaligned accesses when using > eth_get_headlen on a page that was DMA aligned instead of being IP aligned. > The fact is when trying to check the length we don't need to be looking at > the flow label so we can reorder the checks to first check if we are > supposed to gather the flow label and then make the call to actually get > it. > > Reported-by: Sowmini Varadhan <sowmini.varad...@oracle.com> > Signed-off-by: Alexander Duyck <adu...@mirantis.com> > ---
You did not quite follow the discussion Alexander, we did not exactly took a decision about this bug. As we mentioned, there are other parts that need care. key_keyid->keyid = *keyid; Please address them, instead of having to 'wait' for the next crash. BTW, even a memcpy(&key_addrs->v4addrs, &iph->saddr, 8) could crash, as the compiler can certainly assume src and dst are 4 bytes aligned, and could use word accesses when inlining memcpy() even on Sparc. Apparently the compiler used by Sowmini is gentle. Thanks.
