On Fri, Jan 29, 2016 at 11:42 AM, Larry Finger
<larry.fin...@lwfinger.net> wrote:
>
> Thanks for testing.
>
> Upon reflection, it really should check the other WIRELESS_MODE_AC_x bits.
> Johannes' patch was indeed correct.

I just retested with this incremental (and whitespace-damaged) patch:

  @@ -139,7 +139,9 @@ static void _rtl_rc_rate_set_series(struct
rtl_priv *rtlpriv,
                       (wireless_mode == WIRELESS_MODE_N_24G)))
                          rate->flags |= IEEE80211_TX_RC_MCS;
                  if (sta && sta->vht_cap.vht_supported &&
  -                   (wireless_mode == WIRELESS_MODE_AC_5G))
  +                   ((wireless_mode == WIRELESS_MODE_AC_5G) ||
  +                    (wireless_mode == WIRELESS_MODE_AC_24G) ||
  +                    (wireless_mode == WIRELESS_MODE_AC_ONLY)))
                          rate->flags |= IEEE80211_TX_RC_VHT_MCS;
          }
   }

which brings it in line with Johannes' patch, and it does indeed still work.

I think marking it for stable is also the right thing to do - the
driver clearly doesn't work well in a wide-channel AC environment
otherwise, and I assume it's going to be more and more common..

                Linus

Reply via email to