On Thu, Jan 28, 2016 at 5:13 AM, Eric Dumazet <eduma...@google.com> wrote: > On Wed, Jan 27, 2016 at 11:33 PM, Mahesh Bandewar <mah...@bandewar.net> wrote: >> From: Mahesh Bandewar <mahe...@google.com> >> >> When we create IPvlan slave; we use ether_setup() and that >> sets up default MTU to 1500 while the master device may have >> lower / different MTU. Any subsequent changes to the masters' >> MTU are reflected into the slaves' MTU setting. However if those >> don't happen (most likely scenario), the slaves' MTU stays at >> 1500 which could be bad. >> >> This change adds code to inherit MTU from the master device >> instead of using the default value during the link initialization >> phase. >> >> Signed-off-by: Mahesh Bandewar <mahe...@google.com> >> CC: Eric Dumazet <eric.duma...@gmail.com> >> CC: Tim Hockins <thock...@google.com> >> > > Acked-by: Eric Dumazet <eduma...@google.com> > > Two points Mahesh : > > 1) ipvlan_adjust_mtu() could be static, it is only used from > drivers/net/ipvlan/ipvlan_main.c > Correct, I'm working on a some other (generic) changes and I could include this suggestion as part of that / later patch or do you prefer it to be part of this change?
> 2) mtu_adj does not seem to be used ? mtu_adj is set to zero so that it follows the master. The idea behind this field was that if enhancements / changes to the IPvlan driver (some sort of built-in encapsulation etc.) is added, this can be set to that magic value so that changes to master will still allow slaves to follow it without compromising the built-in mechanism.
