From: Giuseppe CAVALLARO <peppe.cavall...@st.com>
Date: Tue, 5 Jan 2016 10:03:28 +0100

> On 1/5/2016 4:25 AM, David Miller wrote:
>> From: Giuseppe Cavallaro <peppe.cavall...@st.com>
>> Date: Mon, 4 Jan 2016 14:06:46 +0100
>>
>>> @@ -376,7 +376,8 @@ extern const struct stmmac_desc_ops ndesc_ops;
>>>   /* Specific DMA helpers */
>>>   struct stmmac_dma_ops {
>>>     /* DMA core initialization */
>>> -   int (*init) (void __iomem *ioaddr, int pbl, int fb, int mb,
>>> +   int (*reset)(void __iomem *ioaddr);
>>> +   void (*init)(void __iomem *ioaddr, int pbl, int fb, int mb,
>>>                  int burst_len, u32 dma_tx, u32 dma_rx, int atds);
>>
>> Since you change the return type of the 'init' method, and this
>> changes the column of the openning parenthesis, you have to fix the
>> indentation of the argument list on the next line.
>>
> 
> hmm, lines are well aligned.
> 
> I will check again, in case of I introduced some indentation problem.

Either it was wrong to begin with (I checked before I replied to this posting
and didn't see a misalignment) or it is wrong after the change since void is
one more column more than int.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to