Le 24/12/2015 05:37, Pravin Shelar a écrit :
On Wed, Dec 23, 2015 at 6:57 PM, David Miller <da...@davemloft.net> wrote:
From: Pravin B Shelar <pshe...@nicira.com>
Date: Wed, 23 Dec 2015 15:52:03 -0800

       } else {
-             err_stats->tx_dropped++;
+             struct net_device_stats *err_stats = &dev->stats;
+
+             if (err < 0) {
+                     err_stats->tx_errors++;
+                     err_stats->tx_aborted_errors++;
+             } else {
+                     err_stats->tx_dropped++;
+             }

The original code did not have this "tx_dropped" code path
and you aren't explaining in your commit message why you
are adding this new behavior.

There is "tx_dropped" code path in existing iptunnel_xmit_stats(). I
have only moved err_stats variable definition to local block.
There is no new behavior in this patch.

Yes, I think it's ok now. There is no functional change. The prototype
of the function has changed: err_stats is not provided anymore in the arguments.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to