On 12/12/2015 2:09 AM, David Miller wrote:
From: Giuseppe Cavallaro <peppe.cavall...@st.com>
Date: Wed, 9 Dec 2015 09:37:52 +0100
@@ -98,6 +98,10 @@ static int buf_sz = DEFAULT_BUFSIZE;
module_param(buf_sz, int, S_IRUGO | S_IWUSR);
MODULE_PARM_DESC(buf_sz, "DMA buffer size");
+static int minrx = 256;
+module_param(minrx, int, S_IRUGO | S_IWUSR);
+MODULE_PARM_DESC(minrx, "Copy only tiny-frames");
+
When you type module_param() in a network driver, you ought to receive
an electric shock in order to remind you that except in the most extreme
cases module parameters are absolutely not appropriate.
In this case we have an ethtool tunable people can use to control copy
break values like this, so use that instead.
ok, v2 will have this change. Let me know if there is other to fix.
Peppe
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
