On Tue, 2015-12-01 at 14:47 -0800, Cong Wang wrote: > On Tue, Dec 1, 2015 at 2:33 PM, Eric Dumazet <eric.duma...@gmail.com> wrote: > > Hmm... it looks like we have a much more serious bug : > > > > qdisc_lookup() calls qdisc_match_from_root(dev->qdisc, handle) without > > proper lock being held, so we might actually crash the host, > > if qdisc_tree_decrease_qlen() happens at the time qdiscs are changed. > > > > qdisc_tree_decrease_qlen() needs serious care :( > > Convert qdisc list to RCU protected?
Yes, or/and add a per txqueue list, to shorten lookup times ! If we have a per txqueue list, we do not need RCU as we already own the qdisc lock. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
