On Tue, Nov 24, 2015 at 9:16 AM, Florian Westphal <f...@strlen.de> wrote: > Tom Herbert <t...@herbertland.com> wrote: >> No one is being forced to use any of this. > > Right. But it will need to be maintained. > Lets ignore ktls for the time being and focus on KCM. > > I'm currently trying to figure out how memory handling in KCM > is supposed to work. > > say we have following record framing: > > struct record { > u32 len; > char data[]; > }; > > And I have a epbf filter that returns record->len within KCM. > Now this program says 'length 128mbyte' (or whatever). > > If this was userspace, things are simple, userspace can either > decide to hang up or start to read this in chunks as data arrives. > > AFAICS, with KCM, the kernel now has to keep 128mb of allocated > memory around, rmem limits are ignored. > > Is that correct? What if next record claims 4g in size? > I don't really see how we can make any guarantees wrt. > kernel stability... > > Am I missing something?
Message size limits can be enforced in BPF or we could add a limit enforced by KCM. For instance, the message size limit in http/2 is 16M. If it's needed, it wouldn't be much trouble to add a streaming interface for large messages. > > Thanks, > Florian -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html