From: Eric Dumazet <eric.duma...@gmail.com> Date: Thu, 19 Nov 2015 13:43:45 -0800
> On Thu, 2015-11-19 at 16:06 -0500, Aaron Conole wrote: > >> > >> >> Would the following be an appropriate change in addition to the one >> you've posted, then? If so I can repost as a formal patch, if you'd >> like. At present, there's only one user of napi_frags_skb(), and your >> patch removes the NULL check. If this can really only be the result of >> buggy driver, then perhaps we should just call out the bug? > > Lets mark my patch as "premature" optimization, and revisit whole thing > after audit of the 10 drivers using this interface ;) Also BUG_ON() is way too large a hammer. An attempt to continue should be made in some way, so that person inspecting the message and still have a network and work on fixing the driver after the check triggers :-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
