Hello! David Miller schrieb am Fri, 23 Oct 2015 03:30:48 -0700 (PDT):
From: Guillaume Nault <g.na...@alphalink.fr> Date: Thu, 22 Oct 2015 16:57:10 +0200We can't rely on PPPOX_ZOMBIE to decide whether to clear po->pppoe_dev. PPPOX_ZOMBIE can be set by pppoe_disc_rcv() even when po->pppoe_dev is NULL. So we have no guarantee that (sk->sk_state & PPPOX_ZOMBIE) implies (po->pppoe_dev != NULL). Since we're releasing a PPPoE socket, we want to release the pppoe_dev if it exists and reset sk_state to PPPOX_DEAD, no matter the previous value of sk_state. So we can just check for po->pppoe_dev and avoid any assumption on sk->sk_state. Fixes: 2b018d57ff18 ("pppoe: drop PPPOX_ZOMBIEs in pppoe_release") Signed-off-by: Guillaume Nault <g.na...@alphalink.fr>Applied and queued up for -stable, thanks.
Somehow this commit (1acea4f6ce1b1c0941438aca75dd2e5c6b09db60) did not make it into Linux 4.2.6, 4.1.13, or 3.18.24. But I don't find it in your stable bundle on Patchwork either. Has this patch been inadvertently "lost in translation"?
Best regards, -- Christoph Schulz -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
