Hi Andrew,

On 11/19/2015 12:29 AM, Andrew Lunn wrote:
> +             gpio = of_get_named_gpio_flags(child, "reset-gpios", 0,
> +                                            &flags);
> +             if (gpio_is_valid(gpio)) {
> +                     ret = devm_gpio_request_one(dev, gpio, flags,
> +                                                 "switch_reset");
> +                     if (ret)
> +                             goto out_free_chip;
> +
> +                     cd->reset = gpio;
> +                     cd->reset_flags = flags;
> +                     off = (flags && OF_GPIO_ACTIVE_LOW ? 1 : 0);
> +                     gpio_direction_output(cd->reset, off);
> +             }
> +
>               for_each_available_child_of_node(child, port) {
>                       port_reg = of_get_property(port, "reg", NULL);
>                       if (!port_reg)
> 

You could also use :
gpio = of_get_named_gpio(child, "reset-gpios", 0)
devm_gpio_request(dev, gpio, "switch_reset")

and :
cd->reset = gpio_to_desc(gpio);

and cd->switch reset to struct gpio_desc *reset

to use the gpiod calls afterward. The flags are no more needed.

Neil
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to