On Tuesday 17 November 2015, Francois Romieu wrote: > Ondrej Zary <li...@rainbow-software.org> : > > If memory allocation fails in alloc_list(), free the already allocated > > memory and return -ENODEV. In rio_open(), call alloc_list() first and > > abort if it fails. Move HW access (set RFDListPtr) out ot alloc_list(). > > > > Signed-off-by: Ondrej Zary <li...@rainbow-software.org> > > ENODEV vs ENOMEM aside, it's ok with me.
Will fix the description in v2. > The driver may avoid depleting the receive ring when > netdev_alloc_skb_ip_align fails in receive_packet (drop and increase > stats->rx_dropped). > > Then you may replace the pci_* dma helpers with the plain dma_* ones (they > can fail). > > And perform a plain napi conversion. NAPI is on the todo list. Thanks for suggestions. -- Ondrej Zary -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
