David Miller <da...@davemloft.net> writes: > From: Mans Rullgard <m...@mansr.com> > Date: Mon, 16 Nov 2015 18:23:35 +0000 > >> +static int nb8800_alloc_rx(struct net_device *dev, int i, bool napi) > > "i" is passed in as a signed int here, but: > >> +static void nb8800_receive(struct net_device *dev, unsigned i, unsigned len) > ... >> + err = nb8800_alloc_rx(dev, i, true); > > It comes from an 'unsigned' value. > > Please pick one type and use it consistently.
Darn, missed one. > Also, always fully spell out "unsigned int" rather than use "unsigned" > as a shorthand. OK Anything else? -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
