On Tue, 2015-11-10 at 21:21 +0000, Måns Rullgård wrote: > Even ixgbe uses napi_complete() while netdevice.h says one should > "consider using napi_complete_done() instead." Did the author consider > it and decide not to, or has the driver simply not been updated?
napi_complete_done() is quite new, very few drivers use it. It still requires a tuning (/sys/class/net/ethX/gro_flush_timeout) > > As for the napi_gro_receive() function, calling that instead of > netif_receive_skb() is easy enough, or are there other things I should > be doing in addition? Nothing comes to mind, if you already have a NAPI context, napi_gro_receive() is the way to go... -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
