Hello,

On Fri, 6 Nov 2015, Neil Horman wrote:

> The solution is to recognize that its pointless to promote an address to be a
> new primary, if there is a possibility that it will just be removed in the 
> near
> future.  As such this patch peeks ahead to the next request in the provided
> netlink message, and, if it is both valid and a RTM_DELADDR request, skips the
> promotion check.  This eliminates the need to iterate through a nested for 
> loop

        flush can provide many parameters. As there is no
any kind of indication in the netlink message that all addresses
are removed, we can not avoid the promotion.

> +      * Only check for address promotion when this is the last request
> +      * in this netlink transaction.  It allows this operation to complete
> +      * in O(n) time rather than O(n^2)

        It is not correct to assume that one promotion per
transaction is enough. The promotion happens in every subnet,
it was not once per device.

Regards

--
Julian Anastasov <j...@ssi.bg>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to