On 11/03/2015 09:36 PM, Jarod Wilson wrote:
> With moving netdev_sync_lower_features() after the .ndo_set_features
> calls, I neglected to verify that devices added *after* a flag had been
> disabled on an upper device were properly added with that flag disabled as
> well. This currently happens, because we exit __netdev_update_features()
> when we see dev->features == features for the upper dev. We can retain the
> optimization of leaving without calling .ndo_set_features with a bit of
> tweaking and a goto here.
>
> Changing err to ret was somewhat arbitrary and makes the patch look more
> involved, but seems to better fit the altered use.
>
> Fixes: fd867d51f ("net/core: generic support for disabling netdev features
> down stack")
> CC: "David S. Miller" <da...@davemloft.net>
> CC: Eric Dumazet <eduma...@google.com>
> CC: Jay Vosburgh <j.vosbu...@gmail.com>
> CC: Veaceslav Falico <vfal...@gmail.com>
> CC: Andy Gospodarek <go...@cumulusnetworks.com>
> CC: Jiri Pirko <j...@resnulli.us>
> CC: Nikolay Aleksandrov <ra...@blackwall.org>
> CC: Michal Kubecek <mkube...@suse.cz>
> CC: Alexander Duyck <alexander.du...@gmail.com>
> CC: netdev@vger.kernel.org
> Signed-off-by: Jarod Wilson <ja...@redhat.com>
> ---
> net/core/dev.c | 21 ++++++++++++---------
> 1 file changed, 12 insertions(+), 9 deletions(-)
>
Thanks for the quick response,
Reported-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>
Tested-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>
Acked-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>
Fixes: fd867d51f889 ("net/core: generic support for disabling netdev features
down stack")
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
