From: Padmanabh Ratnakar <padmanabh.ratna...@avagotech.com> Date: Tue, 3 Nov 2015 20:25:59 +0530
> NIC drivers mark device as detached during error recovery. > It expects no manangement hooks to be invoked in this state. > Invoke driver vlan hooks only if device is present. > > Signed-off-by: Padmanabh Ratnakar <padmanabh.ratna...@avagotech.com> I don't like this. This approach to solving the issue just peppers checks randomly around the kernel and the risk for missing cases is very high. It is also not clear to me what exactly specifies that these calls are not valid in such states. Traditionally we've depended upon the driver to make this kind of check in it's callback, and that way we don't need to add extra overhead for everyone at all of these method invokcation points. Therefore, I would like to see a less dirty, and less error prone approach to solving this bug. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
