On Fri, Oct 23, 2015 at 01:48:49PM +0900, YOSHIFUJI Hideaki wrote:
> Hi,
>
> John W. Linville wrote:
> > NOTE: Link-local IPv6 addresses for remote endpoints are not supported,
> > since the driver currently has no capacity for binding a geneve
> > interface to a specific link.
> >
> > Signed-off-by: John W. Linville <linvi...@tuxdriver.com>
> > ---
> > v5:
> > - wrap declaration of sock6 in geneve_dev with IS_ENABLED(CONFIG_IPV6)
> > - remove superfluous '!!' when assigning geneve->collect_md to bool
> > - use skb_scrub_packet in IPv4 tx path as well
> > - check for NULL ip_tunnel_info pointer in geneve[6]_xmit_skb
> > - use ipv6_addr_equal for comparing IPv6 addresses
> > - more use of IS_ENABLED(CONFIG_IPV6) for preserving build integrity
> > - reject link-local ipv6 address for remote tunnel endpoint
> :
>
> > @@ -870,15 +1147,35 @@ static int geneve_newlink(struct net *net, struct
> > net_device *dev,
> :
> > +
> > + if (ipv6_addr_type(&remote.sin6.sin6_addr) &
> > + IPV6_ADDR_LINKLOCAL)
> > + netdev_dbg(dev, "link-local remote is unsupported\n");
> > + return -EINVAL;
> > + }
> > +
>
> This always returns -EINVAL; {} is missing.
Yikes! I posted the wrong patch...good eyes!
I will repost...
John
--
John W. Linville Someday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
