On 20/10/15 14:28, Andrew F. Davis wrote: > Add support for the TI DP83848 Ethernet PHY device. > > The DP83848 is a highly reliable, feature rich, IEEE 802.3 compliant > single port 10/100 Mb/s Ethernet Physical Layer Transceiver supporting > the MII and RMII interfaces. > > Signed-off-by: Andrew F. Davis <a...@ti.com> > Signed-off-by: Dan Murphy <dmur...@ti.com>
Reviewed-by: Florian Fainelli <f.faine...@gmail.com> Just one comment below: [snip] > diff --git a/drivers/net/phy/Makefile b/drivers/net/phy/Makefile > index 87f079c..b748224 100644 > --- a/drivers/net/phy/Makefile > +++ b/drivers/net/phy/Makefile > @@ -24,6 +24,7 @@ obj-$(CONFIG_MDIO_BITBANG) += mdio-bitbang.o > obj-$(CONFIG_MDIO_GPIO) += mdio-gpio.o > obj-$(CONFIG_NATIONAL_PHY) += national.o > obj-$(CONFIG_DP83640_PHY) += dp83640.o > +obj-$(CONFIG_DP83848_PHY) += dp83848.o > obj-$(CONFIG_DP83867_PHY) += dp83867.o This is a pretty small PHY driver, would it make sense to look into consolidating these into e.g: dp838xx.c for instance? dp83640 is big enough to be its own driver it seems. -- Florian -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
