Oliver Neukum <oneu...@suse.com> writes: > On Tue, 2015-10-20 at 10:43 +0200, Bjørn Mork wrote: > >> So we might need to move cdc_parse_cdc_header() out of usbnet.c after >> all. Keeping it there creates an unnecessary "select" mess. But I don't >> know where to put it... Either a common CDC helper module or the USB >> core I guess. > > A common module means that the overhead of a module would be incurred. > Do you have any other candidates that could go into a common helper > module?
Not anything that matters. Some of the CDC notification handling could maybe be shared by using a shoehorn on it, but I think that would make the code less maintainable so it is not a good idea. So, no, I don't have any other candidates. "usbcore" looks like the best place for this function, if that is acceptable to Greg. Bjørn -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
