On Sun, 2015-10-18 at 22:19 -0700, Stephen Hemminger wrote:
> On Sat, 17 Oct 2015 00:21:44 -0400
> Michael Chan <mc...@broadcom.com> wrote:
>
> > +static bool bnxt_vf_pciid(int idx)
> > +{
> > + if (idx == BCM57304_VF || idx == BCM57404_VF)
> > + return true;
> > + return false;
> > +}
> > +
>
> I prefer just returning result of logical operation
> rather than adding unnecessary if statement.
> And never use (signed) int when unsigned is the real
> data type. Also avoid any unnecessary expansion of 16 bit
> value.
>
> static bool bnxt_vf_pciid(u16 idx)
> {
> return (idx == BCM57304_VF || idx == BCM57404_VF);
> }
idx is actually type enum. Other points well taken.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
