On Wed, Oct 14, 2015 at 11:17:03PM +0100, Ian Morris wrote:
> Cleanses some whitespace issues by removing a leading space before a tab.
>
> No changes detected by objdiff.
>
> Signed-off-by: Ian Morris <i...@chirality.org.uk>
> ---
> net/ipv4/netfilter/ipt_ECN.c | 2 +-
> net/ipv4/netfilter/nf_nat_pptp.c | 2 +-
> net/ipv4/netfilter/nf_nat_snmp_basic.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/net/ipv4/netfilter/ipt_ECN.c b/net/ipv4/netfilter/ipt_ECN.c
> index 2707652..6592708 100644
> --- a/net/ipv4/netfilter/ipt_ECN.c
> +++ b/net/ipv4/netfilter/ipt_ECN.c
> @@ -24,7 +24,7 @@ MODULE_AUTHOR("Harald Welte <lafo...@netfilter.org>");
> MODULE_DESCRIPTION("Xtables: Explicit Congestion Notification (ECN) flag
> modification");
>
> /* set ECT codepoint from IP header.
> - * return false if there was an error. */
> + * return false if there was an error. */
In netdev coding style we prefer for multiline comments:
/* This is a comment blah blah blah blah blah blah blah blah blah blah blah blah
* blah blah blah.
*/
For single line:
/* This is a comment blah blah blah */
This case, I suggest we can even get rid of that comment there since
it's obvious what set_ect_ip() is doing by reading the function name
and looking at what it returns.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
