On Wed, Oct 07, 2015 at 15:09:57 -0400, Neil Horman wrote: > On Wed, Oct 07, 2015 at 09:21:40AM +0530, Hariprasad Shenai wrote: > > t4_check_fw_version() can return several error codes (-EINVAL, -EBUSY, > > -EAGAIN). The present code sets the adapter state to UNINIT only if its > > an EFAULT. In all the error cases set the adapter to uninitialized state. > > > > In t4_check_fw_version() if call to t4_read_flash() fails, repeat the > > operation a few times before returning failure. > > > > Signed-off-by: Hariprasad Shenai <haripra...@chelsio.com> > > --- > > drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 2 +- > > drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 6 +++++- > > 2 files changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c > > b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c > > index 9f1f5b2..c29227e 100644 > > --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c > > +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c > > + ret = t4_get_fw_version(adap, &adap->params.fw_vers); > > + > Shouldn't you only retry if you get an error that indicates the error is > transient (i.e. EBUSY or EAGAIN)? > Neil > Yes you are right. Will send a V2 for the same.
Thanks Hari > > > if (ret) > > return ret; > > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
