Thanks for your time and the review. David Miller <da...@davemloft.net> writes: > From: Aaron Conole <acon...@bytheb.org> > Date: Mon, 21 Sep 2015 20:27:02 -0400 > >> + goto unlock; > > Sorry, I don't want to see goto's from one loop into a completely > different one.
I think you misread. This goto does not do that; it goes from the else side of one if block, into a different if block within the same do/while pair. I assumed this was okay, because in commit:b48732e4a48d80ed4a14812f0bab09560846514e the same type of goto unlock jump is used. Since that commit was accepted 4 months ago, I figured the style hadn't changed. Would you rather see: + unix_state_unlock(sk); + break; > The XXX comment is probably not appropriate either. Agreed, any v4 post will not include it. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
