From: Weidong Wang <wangweido...@huawei.com>
Date: Tue, 22 Sep 2015 20:42:40 +0800

> @@ -880,6 +882,7 @@ bnx2_alloc_mem(struct bnx2 *bp)
>               }
>       }
> 
> +     spin_lock(&bp->stats64_lock);
>       bp->stats_blk = status_blk + status_blk_size;
> 
>       bp->stats_blk_mapping = bp->status_blk_mapping + status_blk_size;
> @@ -894,20 +897,23 @@ bnx2_alloc_mem(struct bnx2 *bp)
>                                               &bp->ctx_blk_mapping[i],
>                                               GFP_KERNEL);
>                       if (bp->ctx_blk[i] == NULL)
> -                             goto alloc_mem_err;
> +                             goto free_stats64_lock;
>               }
>       }
> 
>       err = bnx2_alloc_rx_mem(bp);
>       if (err)
> -             goto alloc_mem_err;
> +             goto free_stats64_lock;

You're holding a spinlock while doing GFP_KERNEL allocations.

Second of all, taking a spinlock in get_stats64() defeats the whole
intention of making statistics acquisition as fast and as SMP scalable
as possible.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to