> -----Original Message----- > From: Scott Feldman [mailto:sfel...@gmail.com] > Sent: Saturday, September 19, 2015 10:51 PM > To: Jiri Pirko > Cc: Netdev; Siva Mannem; Premkumar Jonnala; step...@networkplumber.org; > Roopa Prabhu; and...@lunn.ch; Florian Fainelli; Vivien Didelot > Subject: Re: [PATCH net-next 4/7] bridge: define some min/max ageing time > constants we'll use next > > On Fri, Sep 18, 2015 at 11:45 PM, Jiri Pirko <j...@resnulli.us> wrote: > > Fri, Sep 18, 2015 at 09:55:48PM CEST, sfel...@gmail.com wrote: > >>From: Scott Feldman <sfel...@gmail.com> > >> > >>Signed-off-by: Scott Feldman <sfel...@gmail.com> > >>--- > >> include/linux/if_bridge.h | 4 ++++ > >> 1 file changed, 4 insertions(+) > >> > >>diff --git a/include/linux/if_bridge.h b/include/linux/if_bridge.h > >>index dad8b00..6cc6dbc 100644 > >>--- a/include/linux/if_bridge.h > >>+++ b/include/linux/if_bridge.h > >>@@ -46,6 +46,10 @@ struct br_ip_list { > >> #define BR_LEARNING_SYNC BIT(9) > >> #define BR_PROXYARP_WIFI BIT(10) > >> > >>+/* values as per ieee8021QBridgeFdbAgingTime */ > >>+#define BR_MIN_AGEING_TIME (10 * HZ) > >>+#define BR_MAX_AGEING_TIME (1000000 * HZ) > > > > I think that a bridge patch checking against these values should be > > introduced along with these values, in the same patchset > > I need the MIN value for this patchset in rocker's ageing timer, so > it's introduced here. MIN/MAX will be used again in follow-on patch > Prem is going to send to range check user input.
Ack that. I will add those checks as part of the patch for iproute2. -Prem