On Fri, Sep 18, 2015 at 07:04:09PM +0300, Stas Sergeev wrote: > 18.09.2015 18:43, Russell King - ARM Linux пишет: > > On Fri, Sep 18, 2015 at 05:45:27PM +0300, Stas Sergeev wrote: > >> AFAICS if it has use_inband_status==true, > >> then it went through of_phy_register_fixed_link(dn), > > > > That's totally incorrect. The test for setting use_inband_status in > > mvneta is: > > > > err = of_property_read_string(dn, "managed", &managed); > > pp->use_inband_status = (err == 0 && > > strcmp(managed, "in-band-status") == 0); > > Arrrr! I was looking at the branch without the last > patch applied, so it occurred to me as > > pp->use_inband_status = (phy_mode == PHY_INTERFACE_MODE_SGMII) && > fixed_phy; > > Sorry for that.
Yay :) > So we seem to indeed have a nasty regression with the patch > that just went to stable. :( Great news. Yes. > Thanks for you time. > > I still have problems with this part though: > > If there's neither a MDIO PHY nor a fixed-link, then the network driver > > fails to initialise the device. > > I think I am looking into the right source this time, seems like > if we don't have both but still have managed="in-band-status", that > should go the fixed-link path and still work... no? If we have no fixed-link and no phy, then you're correct. However, I really don't like the idea of abusing "fixed-link" as a method to generate an ethtool/miitool/miidiag compatible output for this, but I'm willing to let that pass for the moment. :) -- FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
