On Tue, September 15, 2015 20:10, David Woodhouse wrote:
> On Wed, 2013-09-04 at 21:41 +0100, David Woodhouse wrote:
>> +++ b/drivers/atm/solos-pci.c
>> @@ -1145,19 +1145,19 @@ static int psend(struct atm_vcc *vcc, struct sk_buff
>> *skb)
>> +> > if (skb_headroom(skb) < sizeof(*header)) {
>> +> > > struct sk_buff *nskb;
>> +
>> +> > > nskb = skb_realloc_headroom(skb, sizeof(*header));
>> +> > > if (!nskb) {
>> +> > > > solos_pop(vcc, skb);
>> +> > > > return -ENOMEM;
>> +> > > }
>> +> > > if (skb->truesize != nskb->truesize)
>> +> > > > atm_force_charge(vcc, nskb->truesize - skb->truesize);
>> +
>> +> > > dev_kfree_skb_any(skb);
>> +> > > skb = nskb;
>> > > }
>
> Simon, did you ever test this?
> Can you still (tell me how to) reproduce the original problem? I think
> that sending on br2684 was necessary but not sufficient...?
I'm currently using this but without the call to atm_force_charge().
I don't know how to reproduce the BUG() but it hasn't happened again.
--
Simon Arlott
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
