Hi Sabrina, 2015-09-10 17:19 GMT+08:00 Sabrina Dubroca <s...@queasysnail.net>: > Hello, > > 2015-09-10, 10:54:38 +0800, Hangbin Liu wrote: >> > Can we still modify the behavior of this sysctl? It's already been in >> > Linus's tree for a while, but if we can, I would rather restrict the >> > values we let the user write to accept_ra_min_hop_limit, as anything >> > outside [0..255] does not really make sense. >> >> Yes, so the checked if (in6_dev->cnf.accept_ra_min_hop_limit < 256 && >> ra_msg->icmph.icmp6_hop_limit) make sure we only update the value between >> [1..255]. > > I was thinking of returning -EINVAL when the user tries to set it to > 300, using proc_dointvec_minmax.
I'm OK with this. But we can also set cnf.hop_limit to 300, if add check for accept_ra_min_hop_limit, we'd better check all hop_limit values. Thanks Hangbin -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
