On Tue, 2015-09-01 at 13:55 -0700, Martin KaFai Lau wrote: > On Tue, Sep 01, 2015 at 01:14:20PM -0700, Eric Dumazet wrote: > > It should not be a problem. refcnt is taken when/if necessary (skb > > queued on a qdisc for example) > > > > We have other uses of skb_dst_set_noref() > > > > Please describe the problem ? > The current ip6_tnl_dst_get() does not take the dst refcnt. > > If the dst is released after ip6_tnl_dst_get() and before > skb_dst_set_noref(), would it cause an issue?
We are under rcu here, and a dst in a cache is protected by RCU by definition. skb_dst_set_noref() has following debugging clause, does it trigger for you ? WARN_ON(!rcu_read_lock_held() && !rcu_read_lock_bh_held()); -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
