> -----Original Message----- > From: David Miller [mailto:da...@davemloft.net] > Sent: Tuesday, August 25, 2015 10:20 PM > To: Philip Downey > Cc: kuz...@ms2.inr.ac.ru; jmor...@namei.org; yoshf...@linux-ipv6.org; > ka...@trash.net; linux-ker...@vger.kernel.org; netdev@vger.kernel.org > Subject: Re: [PATCH] IGMP: Inhibit reports for local multicast groups > > From: Philip Downey <pdow...@brocade.com> > Date: Mon, 24 Aug 2015 12:39:17 +0100 > > > +extern int sysctl_igmp_link_local_reports; > ... > > +/* IGMP reports for link-local multicast groups are enabled by default */ > > +#define IGMP_ENABLE_LLM 1 > > + > > +int sysctl_igmp_link_local_reports __read_mostly = IGMP_ENABLE_LLM; > > + > > +#define IGMP_INHIBIT_LINK_LOCAL_REPORTS(_ipaddr) \ > > + (ipv4_is_local_multicast(_ipaddr) && \ > > + (sysctl_igmp_link_local_reports == 0)) > > + > > People know that "1" and "0" means enable and disable respectively, so this > macros is pretty excessive. Just remove it. > > Also, simplify the name of the sysctl to something like > "sysctl_igmp_llm_reports" or similar, and simplify the test against 0 to be in > the canonical "!x" format. Then the test can fit on one > line: > > (ipv4_is_local_multicast(_ipaddr) && !sysctl_igmp_llm_reports).
Thanks for reviewing David. I will make the requested changes (fitting the test on a single line was my main reason for introducing the macro - that and making it patently obvious what the test was doing. Your suggestion would seem to meet that aim). Will amend and resubmit. Regards Philip -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
