On Tue, 18 Aug 2015 20:21:10 -0700, Tom Herbert wrote: > diff --git a/include/net/lwtunnel.h b/include/net/lwtunnel.h > index e25b60e..9bf7e6a 100644 > --- a/include/net/lwtunnel.h > +++ b/include/net/lwtunnel.h > @@ -26,7 +26,8 @@ struct lwtunnel_state { > > struct lwtunnel_encap_ops { > int (*build_state)(struct net_device *dev, struct nlattr *encap, > - struct lwtunnel_state **ts); > + struct lwtunnel_state **ts, > + unsigned int family, const void *cfg);
Could you please keep the output parameter as the last one? (It might be better if build_state returned the newly allocated struct instead and used pointer encoded errors but that's for a different patch.) Jiri -- Jiri Benc -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html