On 08/17/2015 05:14 PM, Guenter Roeck wrote:
One nitpick I noticed after sending my patch: dev can never be NULL in
smsc911x_probe_config(), so it does not really make sense to check if it is
NULL.
No, it doesn't... it should really be something like
if (dev_fwnode(dev))
But dev_fwnode is static inline in property.c, and i'm pretty sure that
still isn't 100% correct.The best plan might just be to remove the
check, and abort on failure to find the phy property per your patch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
