On 08/14/15 at 04:40pm, Jiri Benc wrote:
> We already have IFLA_IPTUN_ netlink attributes. The IP_TUN_ attributes look
> very similar, yet they serve very different purpose. This is confusing for
> anyone trying to implement a user space tool supporting lwt.
>
> As the IP_TUN_ attributes are used only for the lightweight tunnels, prefix
> them with LWTUNNEL_IP_ instead to make their purpose clear. Also, it's more
> logical to have them in lwtunnel.h together with the encap enum.
>
> Fixes: 3093fbe7ff4b ("route: Per route IP tunnel metadata via lightweight
> tunnel")
> Signed-off-by: Jiri Benc <jb...@redhat.com>
Acked-by: Thomas Graf <tg...@suug.ch>
> ---
> These are still in net-next only, thus it's safe to change them.
>
> It's still a bit weird these attributes are in RTA_ENCAP, perhaps we should
> also rename RTA_ENCAP to RTA_LWT_ENCAP or similar?
I think RTA_ENCAP is fine but I don't mind changing it either.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
