From: Florian Fainelli <f.faine...@gmail.com>
Date: Sat,  8 Aug 2015 12:58:57 -0700

> In case we need to divert reads/writes using the slave MII bus, we may have
> already fetched a valid PHY interface property from Device Tree, and that
> mode is used by the PHY driver to make configuration decisions.
> 
> If we could not fetch the "phy-mode" property, we will assign p->phy_interface
> to PHY_INTERFACE_MODE_NA, such that we can actually check for that condition 
> as
> to whether or not we should override the interface value.
> 
> Fixes: 19334920eaf7 ("net: dsa: Set valid phy interface type")
> Signed-off-by: Florian Fainelli <f.faine...@gmail.com>
> ---
> Hi Guenter,
> 
> Could you verify this does not break what you were trying to fix with your 
> change?
> I am fairly confident this will not because for "PHYs" built-into the switch 
> port
> we will not be able to fetch a "phy-mode" property from DT, so we will use
> PHY_INTERFACE_MODE_NA, but here, we will re-assign them to 
> PHY_INTERFACE_MODE_GMII
> as before.

I was trying to wait for Guenter's testing before applying this, but it's been 
some
time already and it makes no sense to wait any longer.

Applied to 'net', thanks Florian.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to