Just doing:
ip link add name ipvl0 link eth0 type ipvlan
ip -6 addr add 3333:0:0:1:5555:0:1:1/128 dev ipvl0
ip addr add 192.168.1.1/32 dev iplv0
Before patch:
ping 3333:0:0:1:5555:0:1:1
- No response, tcpdump on ipvl0 shows two copies of each ICMP echo
request.
ping 192.168.1.1
- Works, tcpdump on ipvl0 shows nothing
With patch applied:
ping 3333:0:0:1:5555:0:1:1
- Works, tcpdump on ipvl0 shows nothing
ping 192.168.1.1
- Works, tcpdump on ipvl0 shows nothing
Some other problems I'm seeing
- Occurrence of "Dead loop on virtual device ipvl0, fix it urgently!"
Running following script several times seems to get to the error.
Once in this state machine is pretty locked up:
rmmod ipvlan
for i in `seq 0 199`;
do
ip link add name ipvl$i link eth0 type ipvlan
addr=`echo $i | awk '{printf("%04x", $1)}'`
ip -6 addr add 3333:0:0:1:5555:0:1:$addr/128 dev ipvl$i
ifconfig ipvl$i up
done
- Seeing "Dropped {multi|broad}cast of type= [86dd]"
Looks like this may be from ND messages. Might be innocuous I
suppose, but it is annoying to see in logs.
Signed-off-by: Tom Herbert <t...@herbertland.com>
---
drivers/net/ipvlan/ipvlan_core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ipvlan/ipvlan_core.c b/drivers/net/ipvlan/ipvlan_core.c
index 207f62e..0b68538 100644
--- a/drivers/net/ipvlan/ipvlan_core.c
+++ b/drivers/net/ipvlan/ipvlan_core.c
@@ -277,8 +277,8 @@ static int ipvlan_rcv_frame(struct ipvl_addr *addr, struct
sk_buff *skb,
skb->pkt_type = PACKET_HOST;
if (local) {
- if (dev_forward_skb(ipvlan->dev, skb) == NET_RX_SUCCESS)
- success = true;
+ netif_receive_skb(skb);
+ success = true;
} else {
ret = RX_HANDLER_ANOTHER;
success = true;
@@ -384,7 +384,7 @@ static int ipvlan_process_v6_outbound(struct sk_buff *skb)
struct dst_entry *dst;
int err, ret = NET_XMIT_DROP;
struct flowi6 fl6 = {
- .flowi6_iif = skb->dev->ifindex,
+ .flowi6_oif = dev_get_iflink(dev),
.daddr = ip6h->daddr,
.saddr = ip6h->saddr,
.flowi6_flags = FLOWI_FLAG_ANYSRC,
--
1.8.1
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
