On Tue, Aug 4, 2015 at 1:47 PM, Andy Shevchenko
<andriy.shevche...@linux.intel.com> wrote:
> On Thu, 2015-07-16 at 15:42 +0300, Andy Shevchenko wrote:
>> There is no need to use hex_dump_to_buffer() in the cases like this:
>>
>> hexdump_to_buffer(buf, len, 16, 1, outbuf, outlen, false); > /*
>> len <= 16
>> */
>> sprintf("%s\n", outbuf);
>>
>> since it maybe easily converted to simple:
>>
>> sprintf("%*ph\n", len, buf);
>>
>> Note: it seems in one case the output is groupped by 2 bytes and
>> looks like a
>> typo. Thus, patch changes that to plain byte stream.
>
>
> Any comments on this, anyone?
>
> The idea is to minimize usage of hexdump_to_buffer(), i.e. not using it
> when it's an obvious overkill.
>
Sorry for the delay, since the buffer is small (less than 16 bytes, it
should be fine).
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
