From: Corcodel Marian <corcodel.mar...@gmail.com> Date: Sat, 1 Aug 2015 20:20:21 +0300
> Add parameter ff_dup wich disable advertise 10/100Mbs > duplex full for card wich start on low speed on full duplex.Verry strange > with this patch > First insert module with ff_dup=1 link is good , unload module, load module > wo parameter ff_dup > and is full duplex and full speed on RTL_GIGA_MAC_VER_09. > > Signed-off-by: Corcodel Marian <corcodel.mar...@gmail.com> This patch, like all of your other patches, is not acceptable. First of all, such module parameters are strongly discouraged. Instead, such things should be controlled by portable, generic, run time configurations mechanisms such as ethtool. Furthermore, you are not explaining sufficiently why this configuration option is really needed and in exactly what circumstances they would be used. I want to _STRONGLY_ impress upon you how much time and effort is seemingly being wasted on your poorly thought out and formatted patches. If this continues do not be surprised if you find it hard for people willing to look at your submissions at all. You need to start making clean proper submissions soon. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
