On 7/12/15, 3:06 PM, Daniel Borkmann wrote:
Similarly as in commit 4f7d2cdfdde7 ("rtnetlink: verify IFLA_VF_INFO attributes before passing them to driver"), we have a double nesting of netlink attributes, i.e. IFLA_VF_PORTS only contains IFLA_VF_PORT that is nested itself. While IFLA_VF_PORTS is a verified attribute from ifla_policy[], we only check if the IFLA_VF_PORTS container has IFLA_VF_PORT attributes and then pass the attribute's content itself via nla_parse_nested(). It would be more correct to reject inner types other than IFLA_VF_PORT instead of continuing parsing and also similarly as in commit 4f7d2cdfdde7, to check for a minimum of NLA_HDRLEN.Signed-off-by: Daniel Borkmann <dan...@iogearbox.net> Cc: Roopa Prabhu <ro...@cumulusnetworks.com> Cc: Scott Feldman <sfel...@gmail.com> Cc: Jason Gunthorpe <jguntho...@obsidianresearch.com>
Acked-by: Roopa Prabhu <ro...@cumulusnetworks.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
