From: Alexei Starovoitov <a...@plumgrid.com> Date: Fri, 10 Jul 2015 17:10:11 -0700
> TC actions need to check for very unlikely event skb->users != 1, > otherwise subsequent pskb_may_pull/pskb_expand_head will crash. > When skb_shared() just drop the packet, since in the middle of actions > it's too late to call skb_share_check(), since classifiers/actions assume > the same skb pointer. > > Signed-off-by: Alexei Starovoitov <a...@plumgrid.com> I think whatever creates this skb->users != 1 situation should be fixed, they should clone the packet. In fact, it would really help enormously if you could explain in detail how this situation can actually arise. Especially since I do not consider it acceptable to drop the packet in this situation. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
